Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerfile to build the new kafka output #132

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 2, 2020

What type of PR is this?
/kind bug
/kind cleanup

Any specific area of the project related to this PR?

/area build
/area outputs

What this PR does / why we need it:

The kafka lib we are using is a wrapper of the libkafka written in C/C++ so we need to have a special build for that.

This PR fix the build image and also add a CI job to build the image to avoid issues in the future.

Also:

  • Add some items in the dockerignore
  • Format a bit the imports to follow the go best practices
  • Add the license in the image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana added the kind/bug Something isn't working label Dec 2, 2020
@poiana
Copy link

poiana commented Dec 2, 2020

@cpanato: The label(s) area/build, area/outputs cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind bug
/kind cleanup

Any specific area of the project related to this PR?

/area build
/area outputs

What this PR does / why we need it:

The kafka lib we are using is a wrapper of the libkafka written in C/C++ so we need to have a special build for that.

This PR fix the build image and also add a CI job to build the image to avoid issues in the future.

Also:

  • Add some items in the dockerignore
  • Format a bit the imports to follow the go best practices
  • Add the license in the image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…work

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@poiana poiana added size/L and removed size/M labels Dec 2, 2020
@cpanato cpanato changed the title Fix image Fix dockerfile to build the new kafka output Dec 2, 2020
@poiana poiana added the lgtm label Dec 2, 2020
@poiana
Copy link

poiana commented Dec 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Dec 2, 2020

LGTM label has been added.

Git tree hash: 782efeedd1ff899e5e8c857fbb4decb77edf52d9

@poiana poiana added the approved label Dec 2, 2020
@poiana poiana merged commit 3742f64 into falcosecurity:master Dec 2, 2020
@cpanato cpanato deleted the fix-image branch December 2, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants