Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clean filters to avoid confusion #138

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 11, 2020

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
clean up the filters part on the circleci yaml file to avoid confusion

so in general what we want to achieve with that

  • Jobs lint and test should run for ALL branches, PRs and tags
  • Job build-image should run for any branches and PR, and Not run for master and tags
  • Job build-push-main should run only for master branch

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @Issif

@poiana
Copy link

poiana commented Dec 11, 2020

@cpanato: The label(s) area/build cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
clean up the filters part on the circleci yaml file to avoid confusion

so in general what we want to achieve with that

  • Jobs lint and test should run for ALL branches, PRs and tags
  • Job build-image should run for any branches and PR, and Not run for master and tags
  • Job build-push-main should run only for master branch

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @Issif

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@poiana poiana added the lgtm label Dec 12, 2020
@poiana
Copy link

poiana commented Dec 12, 2020

LGTM label has been added.

Git tree hash: b867d4a9680517914197b4941e065a09b6d53afd

@poiana
Copy link

poiana commented Dec 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 535b0f9 into falcosecurity:master Dec 12, 2020
@cpanato cpanato deleted the clean-ci branch December 12, 2020 14:13
@Issif Issif added this to the 2.20.0 milestone Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants