-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagerduty output support #164
Add pagerduty output support #164
Conversation
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com> For falcosecurity#163
handlers.go
Outdated
@@ -219,4 +219,8 @@ func forwardEvent(falcopayload types.FalcoPayload) { | |||
if config.Kafka.HostPort != "" && (priorityMap[strings.ToLower(falcopayload.Priority)] >= priorityMap[strings.ToLower(config.Kafka.MinimumPriority)] || falcopayload.Rule == TestRule) { | |||
go kafkaClient.KafkaProduce(falcopayload) | |||
} | |||
|
|||
if config.Pagerduty.APIKey != "" && (priorityMap[strings.ToLower(falcopayload.Priority)] >= priorityMap[strings.ToLower(config.Pagerduty.MinimumPriority)] || falcopayload.Rule == TestRule) { | |||
go kafkaClient.PagerdutyPost(falcopayload) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go kafkaClient.PagerdutyPost(falcopayload) | |
go kafkaClient.PagerdutyCreateIncident(falcopayload) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
LGTM label has been added. Git tree hash: bad24233f9d2f4a001f7a8bc5b764b14292e8c6f
|
Thank you! I will prepare chart update tomorrow. |
@KeisukeYamashita I just noticed, all your commits need DCO to be approved. |
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
646eeab
to
c5154ad
Compare
@Issif Thank you, I just signed my commits and CI are passing 🎸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome !!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Many company uses PagerDuty and we want to create a incident on Falco reports.
Which issue(s) this PR fixes:
Fixes #163
Special notes for your reviewer:
These are documents that might help you review: