Kubeless output #170
Merged
Kubeless output #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issif
force-pushed
the
kubeless-output
branch
from
3ba95d9 to
7d9c992
Compare
leogr
reviewed
Jan 12, 2021
KeisukeYamashita
previously approved these changes
Jan 12, 2021
nibalizer
reviewed
Jan 12, 2021
cpanato
requested changes
Jan 13, 2021
There was a problem hiding this comment.
lgtm, just some nits:
- squash the commits to have just one commit
- and just a comment, try to avoid to update dependencies in the PR that does other thing, if the PR need a new dependency is fine, but avoid update non-releated dependencies, we can open a separated PR for that
cpanato
reviewed
Jan 13, 2021
cpanato
reviewed
Jan 13, 2021
Issif
force-pushed
the
kubeless-output
branch
from
716c392 to
d1d64a0
Compare
Signed-off-by: Issif <issif_github@gadz.org>
Issif
force-pushed
the
kubeless-output
branch
from
d1d64a0 to
5ad03b0
Compare
|
@nibalizer @cpanato thanks you both, I used github.com/google/uuid for generating |
|
LGTM label has been added. Git tree hash: 6bc20485b43212b30de3e37da7d6e3f91f74241d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Issif issif_github@gadz.org<!-- Thanks for sending a pull request! Here are some tips for you:
-->
What type of PR is this?
This PR adds add a native integration of
kubelessas new output.Falcosidekickwill be able to trigger akubelessfunction from in/outside a k8s cluster./kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
With a native integration, all intermediate (NATS) and custom components for setting up a response engine become useless.
Which issue(s) this PR fixes:
N/A
Fixes #
Special notes for your reviewer:
cc @cpanato @KeisukeYamashita