Add and use priority type. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Nichols <snichols@vmware.com>
cpanato
approved these changes
Jan 12, 2021
|
LGTM label has been added. Git tree hash: da213d3a28dbd749152d84cfda859021030bcae5
|
|
/hold for others to review if no objection can lift the hold |
KeisukeYamashita
approved these changes
Jan 12, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Issif, KeisukeYamashita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Scott Nichols snichols@vmware.com
/kind cleanup
What this PR does / why we need it:
I was tripping over the string compares so I made a custom json marshaler and holder for the concept of priority.