resolve gosec issues or add nosec annotations #179
Conversation
also fix a couple of linting issues Signed-off-by: Al Stockdill-Mander <asm@uk.ibm.com>
|
/hold |
|
/lgtm Thank you, it's a really valuable PR. Even if all is OK for me, I don't want to merge it right now. From my point of view, if we're trying to respect WDYT @cpanato @KeisukeYamashita @leogr ? |
|
LGTM label has been added. Git tree hash: cf49d9573963c475aac58035d01b3243af8254d2
|
There was a problem hiding this comment.
/lgtm
in the future we might want to return an error here: https://github.com/falcosecurity/falcosidekick/pull/179/files#diff-0e426a43248661127a0c0ee115aef7a1093b635f8993b3f7ebb1dd9f05b8f249R162 and not just log
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel thanks for your PR |
Signed-off-by: Al Stockdill-Mander asm@uk.ibm.com
/kind cleanup
What this PR does / why we need it:
Our build process requires no gosec issues, I have resolved them by appropriate remediation or added nosec annotations with justification.
Also fixed a couple of things the linter was complaining about.