-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output WebUI #180
Output WebUI #180
Conversation
Signed-off-by: Issif <issif_github@gadz.org>
Signed-off-by: Issif <issif_github@gadz.org>
Signed-off-by: Issif <issif_github@gadz.org>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, I left comment regarding the webui.address
field. PTAL when you have a change 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either Web Address or URL would be fine, otherwise it's LGTM!
@KeisukeYamashita I'm ok with your proposal, just FYI, I tried to use same pattern than outputs use in their documentation. For example, Slack calls it For WebUI, as it's our own product, we can do whatever we want. I'll apply your suggestions. Thanks 👍 |
Signed-off-by: Issif <issif_github@gadz.org>
@KeisukeYamashita I did it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating, LGTM 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danpopSD, KeisukeYamashita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: d15d553c1b5a332755e0db702ff769a9f2668409
|
late for the party |
Signed-off-by: Issif issif_github@gadz.org<!-- Thanks for sending a pull request! Here are some tips for you:
-->
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This PR prepares the incoming WebUI for
falcosidekick
as new Output.I need it for using new exported types.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: