-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove quotes in label vue for Loki output #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: f41a2e95006addbfb7bd15dfb8bd6dcf730330d3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/reopen |
@leogr: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reopening to let poiana do its thing |
Pod logs for tide say:
can a maintainer here verify that? |
Found the issue (see the attached screenshot). |
Signed-off-by: Issif <issif_github@gadz.org>
Signed-off-by: Issif <issif_github@gadz.org>
6c3f613
to
ad03b01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this time is the good one 😸
LGTM label has been added. Git tree hash: 4e7578e46fc3bd2c99633600aea79a19453b6e5f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Issif issif_github@gadz.org
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Label values for
Loki
don't support"
.Which issue(s) this PR fixes:
Fixes #181
Special notes for your reviewer: