Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove quotes in label vue for Loki output #182

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Conversation

Issif
Copy link
Member

@Issif Issif commented Feb 6, 2021

Signed-off-by: Issif issif_github@gadz.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Label values for Loki don't support ".

Which issue(s) this PR fixes:

Fixes #181

Special notes for your reviewer:

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@poiana
Copy link

poiana commented Feb 7, 2021

LGTM label has been added.

Git tree hash: f41a2e95006addbfb7bd15dfb8bd6dcf730330d3

@poiana poiana added the approved label Feb 7, 2021
Copy link
Contributor

@KeisukeYamashita KeisukeYamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cpanato
cpanato previously approved these changes Feb 7, 2021
@leogr leogr closed this Feb 7, 2021
@leogr
Copy link
Member

leogr commented Feb 7, 2021

/reopen

@poiana poiana reopened this Feb 7, 2021
@poiana
Copy link

poiana commented Feb 7, 2021

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leogr
leogr previously approved these changes Feb 7, 2021
@fntlnz
Copy link

fntlnz commented Feb 8, 2021

Reopening to let poiana do its thing

@fntlnz fntlnz closed this Feb 8, 2021
@fntlnz fntlnz reopened this Feb 8, 2021
@fntlnz
Copy link

fntlnz commented Feb 8, 2021

Pod logs for tide say:

base branch was modified: Base branch was modified. Review and try the merge again

can a maintainer here verify that?

@leogr
Copy link
Member

leogr commented Feb 8, 2021

Found the issue (see the attached screenshot).
@Issif a manual rebase should fix it, I will re-approve then.
Screenshot from 2021-02-08 11-21-01

Issif added 2 commits February 8, 2021 12:16
Signed-off-by: Issif <issif_github@gadz.org>
Signed-off-by: Issif <issif_github@gadz.org>
@Issif Issif dismissed stale reviews from cpanato and KeisukeYamashita via ad03b01 February 8, 2021 11:17
@Issif Issif force-pushed the fix-loki-k8s-events branch from 6c3f613 to ad03b01 Compare February 8, 2021 11:17
@Issif
Copy link
Member Author

Issif commented Feb 8, 2021

@fntlnz @leogr I did the rebase 👍

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this time is the good one 😸

@poiana poiana added the lgtm label Feb 8, 2021
@poiana
Copy link

poiana commented Feb 8, 2021

LGTM label has been added.

Git tree hash: 4e7578e46fc3bd2c99633600aea79a19453b6e5f

@poiana
Copy link

poiana commented Feb 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d78401f into master Feb 8, 2021
@poiana poiana deleted the fix-loki-k8s-events branch February 8, 2021 11:24
@Issif Issif added this to the 2.21.0 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Log pushes for Kubernetes Audit Events to Loki are failing
6 participants