Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix html template for SMTP #199

Merged
merged 1 commit into from
Mar 3, 2021
Merged

fix html template for SMTP #199

merged 1 commit into from
Mar 3, 2021

Conversation

Issif
Copy link
Member

@Issif Issif commented Mar 3, 2021

Signed-off-by: Issif issif_github@gadz.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Since we changed the type for Priority field in Falcopayload struct from string to PriorityType (

Priority PriorityType `json:"priority"`
), the html template for SMTP output is broken.

2021/02/16 23:11:48 [ERROR] : SMTP - template: html:11:6: executing "html" at <eq .Priority "debug">: error calling eq: incompatible types for comparison

Moreover, with the new design of falco.org, the logo image that was used as email header is not more there. I switched for a logo hosted by CNCF.

Which issue(s) this PR fixes:

#190

Fixes #

Special notes for your reviewer:

… eq' crashed

Signed-off-by: Issif <issif_github@gadz.org>
@Issif Issif added this to the 2.22.0 milestone Mar 3, 2021
@Issif Issif requested a review from cpanato March 3, 2021 14:59
@poiana poiana requested a review from leodido March 3, 2021 14:59
@poiana poiana added the size/S label Mar 3, 2021
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks!

@poiana
Copy link

poiana commented Mar 3, 2021

LGTM label has been added.

Git tree hash: 924c14d083941b258e6387de973c4c4bddf67f67

@poiana
Copy link

poiana commented Mar 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Mar 3, 2021
@poiana poiana merged commit d381ed7 into master Mar 3, 2021
@poiana poiana deleted the fix-smtp-templating branch March 3, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants