Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openfaas output type added #208

Merged
merged 1 commit into from
Mar 14, 2021
Merged

openfaas output type added #208

merged 1 commit into from
Mar 14, 2021

Conversation

developer-guy
Copy link
Contributor

@developer-guy developer-guy commented Mar 11, 2021 •
edited by Issif
Loading

<Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

This PR adds OpenFaaS as an output module. So, we can start sending events to the OpenFaaS functions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana requested review from Issif and leodido March 11, 2021 08:40
@poiana
Copy link

poiana commented Mar 11, 2021

@developer-guy: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link

poiana commented Mar 11, 2021

Welcome @developer-guy! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/L label Mar 11, 2021
@developer-guy
Copy link
Contributor Author

cc @Dentrax

cpanato
cpanato requested changes Mar 11, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment •
edited by Issif
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks fora dding that, in general lgtm, but can you add the the new output in the readme and in the config_example as well?

@developer-guy
Copy link
Contributor Author

thanks fora dding that, in general lgtm, but can you add the the new output in the readme and in the config_example as well?

Of course @cpanato, it is not completed yet, I'm going to complete it tonight 🙋🏻‍♂️

@Issif
Copy link
Member

Issif commented Mar 11, 2021

/hold

@Issif Issif changed the title openfaas output type added WIP: openfaas output type added Mar 11, 2021
@developer-guy
Copy link
Contributor Author

@cpanato, the PR is ready to review now 👍

Issif
Issif reviewed Mar 11, 2021
View reviewed changes
config.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
@developer-guy developer-guy requested review from Issif and cpanato March 12, 2021 07:12
Issif
Issif requested changes Mar 12, 2021
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the README too, please.

  • Add OpenFaas in list of available outputs
  • Add settings in configuration
    • in extract of config_example.yaml
    • in table of env vars

config_example.yaml Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/constants.go Outdated Show resolved Hide resolved
@developer-guy developer-guy requested a review from Issif March 12, 2021 10:49
Issif
Issif reviewed Mar 12, 2021
View reviewed changes
outputs/client.go Outdated Show resolved Hide resolved
@developer-guy developer-guy requested a review from Issif March 12, 2021 13:10
Issif
Issif requested changes Mar 12, 2021
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still remains to complete:

@developer-guy
Copy link
Contributor Author

Still remains to complete:

Completed 👍

@developer-guy developer-guy requested a review from Issif March 12, 2021 20:58
Issif
Issif requested changes Mar 12, 2021
View reviewed changes
outputs/client.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/openfaas.go Outdated Show resolved Hide resolved
outputs/constants.go Outdated Show resolved Hide resolved
outputs/client.go Outdated Show resolved Hide resolved
@developer-guy
openfaas output type added
59ae4b1 
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@Issif Issif changed the title WIP: openfaas output type added openfaas output type added Mar 12, 2021
Issif
Issif approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Thanks for this amazing work and all your patience with my huge amount of comments. Really good job, I'm glad you help us.

@poiana poiana added the lgtm label Mar 12, 2021
@poiana
Copy link

poiana commented Mar 12, 2021

LGTM label has been added.

Git tree hash: dfb4454e8bb03ce861f33e17bf881d8c56aeba4a

@Issif Issif self-requested a review March 12, 2021 22:26
@Issif Issif removed the needs-kind label Mar 12, 2021
@developer-guy
Copy link
Contributor Author

🎉

Thanks for this amazing work and all your patience with my huge amount of comments. Really good job, I'm glad you help us.

It was a honor for me, thank you, I'm really appreciate it🙏🙏

@Issif Issif added this to the 2.22.0 milestone Mar 13, 2021
cpanato
cpanato approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

nice work!! thanks so much for that!

@poiana
Copy link

poiana commented Mar 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a311324 into falcosecurity:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Issif Issif Issif approved these changes

@cpanato cpanato cpanato approved these changes

@leodido leodido Awaiting requested review from leodido

Assignees

@cpanato cpanato

@Issif Issif

Labels
approved dco-signoff: yes lgtm size/L
Projects
Falcosidekick 2.x
Status: Done
Milestone
2.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@developer-guy @poiana @Issif @cpanato