-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rabbitmq type #210
Added rabbitmq type #210
Conversation
@evalsocket: There is not a label identifying the kind of this PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have some linting issues to fix 😉
LGTM label has been added. Git tree hash: 31f2fb1c1cd5a95cbe11c2db553168f0a4f17cfb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
this PR LGTM, thank you! 👍
However, there're merge commits which are not allowed in this repo, and all commits need to be signed-off.
You can fix both with the following one-liner:
git rebase -i --exec 'git commit --amend --no-edit -n -s -S' master
(and resolve conflicts, if any)
Finally, you can git push --force-with-lease
your branch to update this PR.
Thanks in advance, and let me know if you need any support with that.
Signed-off-by: yuvraj <evalsocket@gmail.com>
Signed-off-by: yuvraj <evalsocket@gmail.com>
Signed-off-by: yuvraj <evalsocket@gmail.com>
Signed-off-by: yuvraj <evalsocket@gmail.com>
LGTM label has been added. Git tree hash: b39495780c2b118cba51eec62d9d823fc8f3b207
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yuvraj evalsocket@gmail.com
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it: Added new output type RabbitMQ
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: