Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rabbitmq type #210

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Added rabbitmq type #210

merged 4 commits into from
Mar 26, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Mar 13, 2021

Signed-off-by: Yuvraj evalsocket@gmail.com

What type of PR is this?

kind feature

Any specific area of the project related to this PR?

area outputs

What this PR does / why we need it: Added new output type RabbitMQ

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link

poiana commented Mar 13, 2021

@evalsocket: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Issif Issif self-requested a review March 13, 2021 11:19
@Issif Issif added this to the 2.22.0 milestone Mar 13, 2021
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have some linting issues to fix 😉

config.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
outputs/rabbitmq.go Outdated Show resolved Hide resolved
outputs/rabbitmq.go Show resolved Hide resolved
outputs/rabbitmq.go Outdated Show resolved Hide resolved
outputs/rabbitmq.go Outdated Show resolved Hide resolved
outputs/rabbitmq.go Outdated Show resolved Hide resolved
@yindia yindia changed the title [WIP] Added rabbitmq type Added rabbitmq type Mar 25, 2021
@yindia yindia marked this pull request as ready for review March 25, 2021 18:02
Issif
Issif previously approved these changes Mar 25, 2021
@poiana poiana added the lgtm label Mar 25, 2021
@poiana
Copy link

poiana commented Mar 25, 2021

LGTM label has been added.

Git tree hash: 31f2fb1c1cd5a95cbe11c2db553168f0a4f17cfb

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

this PR LGTM, thank you! 👍

However, there're merge commits which are not allowed in this repo, and all commits need to be signed-off.

You can fix both with the following one-liner:

git rebase -i --exec 'git commit --amend --no-edit -n -s -S' master

(and resolve conflicts, if any)
Finally, you can git push --force-with-lease your branch to update this PR.

Thanks in advance, and let me know if you need any support with that.

yindia added 4 commits March 27, 2021 00:01
Signed-off-by: yuvraj <evalsocket@gmail.com>
Signed-off-by: yuvraj <evalsocket@gmail.com>
Signed-off-by: yuvraj <evalsocket@gmail.com>
Signed-off-by: yuvraj <evalsocket@gmail.com>
@poiana poiana added the lgtm label Mar 26, 2021
@poiana
Copy link

poiana commented Mar 26, 2021

LGTM label has been added.

Git tree hash: b39495780c2b118cba51eec62d9d823fc8f3b207

@poiana
Copy link

poiana commented Mar 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9895bea into falcosecurity:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants