Adds initial support to sending metric alert to wavefront #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @rikatz! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
|
/kind feature |
rikatz
changed the title
|
@rikatz Hello, thank you for this PR, I'll review asap to release it with 2.23.0 which is coming soon (some bug fixes are waiting for) |
|
Great! No rush at all from my part :) |
Issif
requested changes
Apr 16, 2021
poiana
added
dco-signoff: no
do-not-merge/contains-merge-commits
and removed
dco-signoff: yes
needs-rebase
labels
poiana
added
dco-signoff: yes
and removed
dco-signoff: no
do-not-merge/contains-merge-commits
labels
Issif
previously approved these changes
Apr 19, 2021
|
LGTM label has been added. Git tree hash: 3c5ebf77ba3d498b58423bba3a7f0f32ffdd962e
|
|
/hold |
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
|
/hold cancel |
Issif
approved these changes
Apr 19, 2021
|
LGTM label has been added. Git tree hash: fdf26b6f628fa908903a5ab62bac85d994a8e6a7
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? Adds initial support to send alerts as metrics to VMware Wavefront
/area outputs
What this PR does / why we need it:
This adds support for outputing alerts as metrics to Wavefront, keeping Falco tags as Wavefront tags, adding an additional severity tag for people willing to create alerts in future