-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS IRSA support #238
AWS IRSA support #238
Conversation
Welcome @dchoy! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
Use previously created session to avoid using deprecated session.New() Use session.NewSession() to allow AWS IRSA Signed-off-by: David Choy <>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thank you
LGTM label has been added. Git tree hash: a3340462fa9cb2e426ac719ca1d97034ffaa32b1
|
Closing and reopening to trigger the CI |
@leogr: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use previously created session to avoid using deprecated session.New()
Use session.NewSession() to allow AWS IRSA
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #219
Special notes for your reviewer: