-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Kinesis as an output #277
Conversation
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have to add Kinesis in handler.go
too
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh with Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle rotten |
@gauravgahlot what's the issue on your side? I left you a comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the config_example.yaml file too , please
I made the changes you suggested. However, I was not able test everything put together, and that's why I didn't request a review again. |
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
@gauravgahlot thanks. I reviewed, everything seems OK but I didn't tested it myself either. Tell me when you feel confident enough, I'll approve this PR |
Rotten issues close after 30d of inactivity. Reopen the issue with Mark the issue as fresh with Provide feedback via https://github.com/falcosecurity/community. |
@poiana: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gauravgahlot Hello, I know this is a while, but do you think we can merge your PR now? |
@Issif Yes, please. |
LGTM label has been added. Git tree hash: a58b0859da5ae7af3aae63438a95251c6ad45ccf
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravgahlot, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This PR adds AWS Kinesis as an output module.
Which issue(s) this PR fixes:
Fixes #221
Special notes for your reviewer:
Signed-off-by: Gaurav Gahlot gauravgahlot0107@gmail.com