Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Kinesis as an output #277

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

gauravgahlot
Copy link
Contributor

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:

This PR adds AWS Kinesis as an output module.

Which issue(s) this PR fixes:

Fixes #221

Special notes for your reviewer:

Signed-off-by: Gaurav Gahlot gauravgahlot0107@gmail.com

Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
@poiana poiana requested review from developer-guy and Issif October 22, 2021 18:14
@poiana poiana added the size/M label Oct 22, 2021
@Issif Issif self-assigned this Oct 22, 2021
@Issif Issif added this to the 2.25.0 milestone Oct 22, 2021
types/types.go Show resolved Hide resolved
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to add Kinesis in handler.go too

Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
@gauravgahlot gauravgahlot requested a review from Issif October 23, 2021 18:01
@poiana
Copy link

poiana commented Jan 21, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link

poiana commented Feb 20, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@Issif
Copy link
Member

Issif commented Mar 2, 2022

@gauravgahlot what's the issue on your side? I left you a comment

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the config_example.yaml file too , please

@gauravgahlot
Copy link
Contributor Author

@gauravgahlot what's the issue on your side? I left you a comment

I made the changes you suggested. However, I was not able test everything put together, and that's why I didn't request a review again.

Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
@Issif
Copy link
Member

Issif commented Mar 3, 2022

@gauravgahlot thanks. I reviewed, everything seems OK but I didn't tested it myself either. Tell me when you feel confident enough, I'll approve this PR

@poiana
Copy link

poiana commented Apr 2, 2022

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana poiana closed this Apr 2, 2022
@poiana
Copy link

poiana commented Apr 2, 2022

@poiana: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Issif Issif reopened this Apr 26, 2022
@Issif Issif modified the milestones: 2.25.0, 2.26.0 Apr 26, 2022
@Issif
Copy link
Member

Issif commented Apr 26, 2022

@gauravgahlot Hello, I know this is a while, but do you think we can merge your PR now?

@gauravgahlot
Copy link
Contributor Author

@Issif Yes, please.

@poiana poiana added the lgtm label Apr 28, 2022
@poiana
Copy link

poiana commented Apr 28, 2022

LGTM label has been added.

Git tree hash: a58b0859da5ae7af3aae63438a95251c6ad45ccf

@poiana
Copy link

poiana commented Apr 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravgahlot, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit ec6adf9 into falcosecurity:master Apr 28, 2022
@gauravgahlot gauravgahlot deleted the output-aws-kinesis branch April 28, 2022 14:10
@Issif Issif mentioned this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support AWS Kinesis as an output
3 participants