Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build binaries and image for arm64 and arm #288

Merged
merged 3 commits into from
Dec 5, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 5, 2021

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

  • Add targets for arm/v7 and arm64 for both binaries and images

  • Changed the dockerfile to use the binary we already built in the goreleaser definition, so we don't need to rebuild that again.

  • added the build ci pipelines to use goreleaser to build the images as well

tested both arm and arm64 and seems to work fine

/assign @Issif @leogr

  • loading go mod information
   • writing effective config file
      • writing                   config=dist/config.yaml
   • building binaries
      • building                  binary=/home/circleci/project/falcosidekick/dist/falcosidekick_linux_arm_7/falcosidekick
      • building                  binary=/home/circleci/project/falcosidekick/dist/falcosidekick_linux_amd64/falcosidekick
      • building                  binary=/home/circleci/project/falcosidekick/dist/falcosidekick_linux_arm64/falcosidekick
   • archives
      • creating                  archive=dist/falcosidekick_2.16.1-next_linux_arm64.tar.gz
      • creating                  archive=dist/falcosidekick_2.16.1-next_linux_armv7.tar.gz
      • creating                  archive=dist/falcosidekick_2.16.1-next_linux_amd64.tar.gz
   • calculating checksums
      • checksumming              file=falcosidekick_2.16.1-next_linux_amd64.tar.gz
      • checksumming              file=falcosidekick_2.16.1-next_linux_armv7.tar.gz
      • checksumming              file=falcosidekick_2.16.1-next_linux_arm64.tar.gz
   • docker images
      • building docker image     image=falcosecurity/falcosidekick:stable-armv7
      • building docker image     image=falcosecurity/falcosidekick:stable-amd64
      • building docker image     image=falcosecurity/falcosidekick:stable-arm64


circleci@ip-172-28-95-234:~/project/falcosidekick$ docker images
REPOSITORY                                   TAG                 IMAGE ID       CREATED          SIZE
falcosecurity/falcosidekick                  2.16.1-next-arm64   e69d808d5a79   22 seconds ago   46.2MB
falcosecurity/falcosidekick                  stable-arm64        e69d808d5a79   22 seconds ago   46.2MB
public.ecr.aws/falcosecurity/falcosidekick   2.16.1-next-arm64   e69d808d5a79   22 seconds ago   46.2MB
public.ecr.aws/falcosecurity/falcosidekick   stable-arm64        e69d808d5a79   22 seconds ago   46.2MB
falcosecurity/falcosidekick                  2.16.1-next-armv7   27074ae6be1e   24 seconds ago   40MB
falcosecurity/falcosidekick                  stable-armv7        27074ae6be1e   24 seconds ago   40MB
public.ecr.aws/falcosecurity/falcosidekick   2.16.1-next-armv7   27074ae6be1e   24 seconds ago   40MB
public.ecr.aws/falcosecurity/falcosidekick   stable-armv7        27074ae6be1e   24 seconds ago   40MB
falcosecurity/falcosidekick                  2.16.1-next-amd64   c5fc8689377d   27 seconds ago   49.3MB
falcosecurity/falcosidekick                  stable-amd64        c5fc8689377d   27 seconds ago   49.3MB
public.ecr.aws/falcosecurity/falcosidekick   2.16.1-next-amd64   c5fc8689377d   27 seconds ago   49.3MB
public.ecr.aws/falcosecurity/falcosidekick   stable-amd64        c5fc8689377d   27 seconds ago   49.3MB

Which issue(s) this PR fixes:

Fixes #285

Special notes for your reviewer:

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Dec 5, 2021

I will wait to get merged to make other PRs

@poiana poiana added the lgtm label Dec 5, 2021
@poiana
Copy link

poiana commented Dec 5, 2021

LGTM label has been added.

Git tree hash: 5724de80f5fd37e55d32cefffe6ae3f0f7290361

@poiana
Copy link

poiana commented Dec 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 10f128e into falcosecurity:master Dec 5, 2021
@cpanato cpanato deleted the GH-285 branch December 5, 2021 14:55
@Issif Issif added this to the 2.25.0 milestone Mar 2, 2022
@Issif Issif mentioned this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Require image for ARM64 architecture.
4 participants