-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign release artefacts using cosign #302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will work on the new release this month, I would to manage |
@cpanato I created the PR for dealing with source and tags in the events, feel free to rebase this PR on it after |
i can rebase just to make sure, one sec |
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
LGTM label has been added. Git tree hash: 6fb279971631c5d5763edabc1feb874be85e92ee
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Issif when you cut let me know in case we need to tweak anything :) |
I'll ask you to review the PR for the next release anyway 😉 |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Sign the release artefacts using cosign and also generate the SBOM using syft for now
the secret key is already set in circleci
/assign @leogr @Issif
cc @danpopnyc
Which issue(s) this PR fixes:
Fixes #300
Special notes for your reviewer: