Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add templated fields #350

Merged
merged 1 commit into from
Aug 2, 2022
Merged

add templated fields #350

merged 1 commit into from
Aug 2, 2022

Conversation

Issif
Copy link
Member

@Issif Issif commented Jul 28, 2022

Signed-off-by: Issif issif+github@gadz.org

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

This PR introduces new fields that can be added to events, they use go template and output_fields values. See #329 for more details.

Which issue(s) this PR fixes:

#329

Fixes #

Special notes for your reviewer:

@poiana poiana requested review from fjogeleit and leogr July 28, 2022 16:51
@Issif Issif force-pushed the templated-fields branch 2 times, most recently from 98a75cf to b205f21 Compare July 29, 2022 13:43
@Issif Issif changed the title WIP: add templated fields add templated fields Aug 1, 2022
config.go Show resolved Hide resolved
Signed-off-by: Thomas Labarussias <issif+github@gadz.org>
@Issif Issif force-pushed the templated-fields branch from b205f21 to 5c7a896 Compare August 2, 2022 10:20
@poiana
Copy link

poiana commented Aug 2, 2022

LGTM label has been added.

Git tree hash: 860b25a68fd51d8c55e084f02d86564a64bb6734

@poiana
Copy link

poiana commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e41b8a0 into master Aug 2, 2022
@poiana poiana deleted the templated-fields branch August 2, 2022 11:04
@Issif Issif added this to the 2.27.0 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants