-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP feat: Add hostname to payload #355
WIP feat: Add hostname to payload #355
Conversation
Welcome @adnankobir! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adnankobir The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi, |
45756a5
to
98fdb1a
Compare
Agreed, let me added it to the remaining outputs. |
You can take reference with the PR #310 I did it for |
@Issif added to all outputs |
/do-not-merge |
Signed-off-by: Adnan Kobir <adnan.kobir@gmail.com>
Signed-off-by: Adnan Kobir <adnan.kobir@gmail.com>
Signed-off-by: Adnan Kobir <adnan.kobir@gmail.com>
3995247
to
63dda77
Compare
I saw you closed your PR and why. Do you think this one is still relevant? edit: with last version of Falco, it's a dedicated field |
@@ -71,6 +71,10 @@ func (c *Client) WavefrontPost(falcopayload types.FalcoPayload) { | |||
tags["rule"] = falcopayload.Rule | |||
tags["source"] = falcopayload.Source | |||
|
|||
if len(falcopayload.Hostname) != 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if len(falcopayload.Hostname) != 0 { | |
if falcopayload.Hostname != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We added a bunch of new outputs, can you rebase and see if we must add the hostname
either, please
Hi, Can you resolve the conflicts and apply the suggestion I made please, I'm hoping to release the 2.27 in the next 2 weeks |
#383 has been merged, this PR is not useful anymore finally. |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area config
/area outputs
What this PR does / why we need it:
Adds optional
hostname
field to the incoming falco payload. Conditionally adds thehostname
to all outputs.Which issue(s) this PR fixes:
Allows sidekick to retrieve
hostname
once falcosecurity/falco#1520 is resolved.Special notes for your reviewer: