Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spyderbat output #368

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Add Spyderbat output #368

merged 3 commits into from
Oct 19, 2022

Conversation

spyder-kyle
Copy link
Contributor

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:

This PR adds Spyderbat as an output module.

Note: in order for Spyderbat to be able to use the data gathered from Falcosidekick, it needs process IDs, so my PR falcosecurity/falco#2211 needs to be merged for this to be useful.

@poiana
Copy link

poiana commented Sep 20, 2022

Welcome @spyder-kyle! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/XL label Sep 20, 2022
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything seems good, can you just add Spyderbat in the list of available outputs of the readme please

@spyder-kyle
Copy link
Contributor Author

Done, thanks

@spyder-kyle
Copy link
Contributor Author

Actually, it needs to be added to examples as well, right?

@Issif
Copy link
Member

Issif commented Sep 21, 2022

Examples are optionnal, if you have a nice screenshot you can add it for sure

@spyder-kyle
Copy link
Contributor Author

I see, I don't have anything in particular in mind for that then

@Issif
Copy link
Member

Issif commented Oct 18, 2022

I'm waiting for the release of falco 0.33 and I'm approving your PR

outputs/spyderbat.go Outdated Show resolved Hide resolved
Issif
Issif previously approved these changes Oct 19, 2022
@poiana
Copy link

poiana commented Oct 19, 2022

LGTM label has been added.

Git tree hash: b1423fcd91e79bfc8689af393a4a3a274caddeb2

@Issif
Copy link
Member

Issif commented Oct 19, 2022

@spyder-kyle can you rebase on master please

@spyder-kyle
Copy link
Contributor Author

Whoops, misinterpreted that

Signed-off-by: Kyle Smith Hanna <kyle.smithhanna@spyderbat.com>
Signed-off-by: Kyle Smith Hanna <kyle.smithhanna@spyderbat.com>
Signed-off-by: Kyle Smith Hanna <kyle.smithhanna@spyderbat.com>
@poiana poiana added the lgtm label Oct 19, 2022
@poiana
Copy link

poiana commented Oct 19, 2022

LGTM label has been added.

Git tree hash: 9d1b581391ad08c8b2a393efe15a975e83df4bfe

@poiana
Copy link

poiana commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, spyder-kyle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8354d99 into falcosecurity:master Oct 19, 2022
@Issif Issif added this to the 2.27.0 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants