-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spyderbat output #368
Add Spyderbat output #368
Conversation
Welcome @spyder-kyle! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything seems good, can you just add Spyderbat in the list of available outputs of the readme please
Done, thanks |
Actually, it needs to be added to examples as well, right? |
Examples are optionnal, if you have a nice screenshot you can add it for sure |
I see, I don't have anything in particular in mind for that then |
I'm waiting for the release of falco 0.33 and I'm approving your PR |
LGTM label has been added. Git tree hash: b1423fcd91e79bfc8689af393a4a3a274caddeb2
|
@spyder-kyle can you rebase on master please |
Whoops, misinterpreted that |
Signed-off-by: Kyle Smith Hanna <kyle.smithhanna@spyderbat.com>
Signed-off-by: Kyle Smith Hanna <kyle.smithhanna@spyderbat.com>
Signed-off-by: Kyle Smith Hanna <kyle.smithhanna@spyderbat.com>
LGTM label has been added. Git tree hash: 9d1b581391ad08c8b2a393efe15a975e83df4bfe
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, spyder-kyle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This PR adds Spyderbat as an output module.
Note: in order for Spyderbat to be able to use the data gathered from Falcosidekick, it needs process IDs, so my PR falcosecurity/falco#2211 needs to be merged for this to be useful.