Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outputs dirty locking #380

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Conversation

bc-sb
Copy link
Contributor

@bc-sb bc-sb commented Nov 7, 2022

A dirty fix for #375 (comment)

This addresses the short term fix, while a longer term fix will still be required.

@poiana
Copy link

poiana commented Nov 7, 2022

@bc-sb: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana requested review from cpanato and leogr November 7, 2022 22:09
@poiana poiana added the size/M label Nov 7, 2022
@bc-sb bc-sb force-pushed the outputs-dirty-locking branch from 02e2a9a to 37d3155 Compare November 7, 2022 22:10
bc-sb added 2 commits November 7, 2022 22:11
Signed-off-by: Beau Croteau <beau.croteau@spyderbat.com>
Signed-off-by: Beau Croteau <beau.croteau@spyderbat.com>
@bc-sb bc-sb force-pushed the outputs-dirty-locking branch from 37d3155 to 3b1e7c0 Compare November 7, 2022 22:11
@Issif Issif added this to the 2.27.0 milestone Nov 8, 2022
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elasticsearch output is missing in your PR as we use the c.BasicAuth() method it faces same race condition

Signed-off-by: Beau Croteau <beau.croteau@spyderbat.com>
@poiana
Copy link

poiana commented Nov 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bc-sb, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Nov 11, 2022

LGTM label has been added.

Git tree hash: 9af8cf588f5a29ef630fbdc2350eeb182f06a757

@poiana poiana merged commit ce7ffda into falcosecurity:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants