feat(kafka): SASL authentication and additional configuration #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issif
requested changes
Nov 28, 2022
Co-authored-by: Luke Young <lyoung@confluent.io> Co-authored-by: Lyonel Martinez <lyonel.martinez@numberly.com> Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
|
@Issif I did the Co-authored tag |
Issif
approved these changes
Nov 30, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, Lowaiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 2fb861a46865a421fcdeaf9124eea8e996242fe4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Luke Young lyoung@confluent.io
Co-authored-by: Lyonel Martinez lyonel.martinez@numberly.com
Signed-off-by: Lyonel Martinez lyonel.martinez@numberly.com
As the PR looks a bit stalled: Applying changes request from #381
What type of PR is this?
/kind feature
/area outputs
What this PR does / why we need it:
This PR adds some new features to the Kafka output:
All of these features already existed in the latest version of the upstream Kafka library that was already in use, this is mostly just boilerplate to wire up the configuration.
Which issue(s) this PR fixes:
Fixes #273 (not including MTLS support)