Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timescaledb hypertablename config #426

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

alika
Copy link
Contributor

@alika alika commented Mar 20, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area outputs

What this PR does / why we need it:

This fixes an error that occurs when using the TimescaleDB output:
[ERROR] : TimescaleDB - ERROR: syntax error at or near "(" (SQLSTATE 42601).

Turns out because of the config typo fixed in this PR, this line results in an empty string table name and causes the SQL error.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: alika <alika.larsen@gmail.com>
@poiana
Copy link

poiana commented Mar 20, 2023

Welcome @alika! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/XS label Mar 20, 2023
@Issif Issif added this to the 2.28.0 milestone Mar 20, 2023
@poiana
Copy link

poiana commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alika, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Mar 20, 2023

LGTM label has been added.

Git tree hash: 641242d9026bbd339bec166da3c92f7f4c328786

@poiana poiana merged commit de35efd into falcosecurity:master Mar 20, 2023
@alika alika deleted the fix-timescaledb-config branch March 20, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants