Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hostname as prom label for cardinality #427

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

Issif
Copy link
Member

@Issif Issif commented Mar 21, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Fix cardinality issue with Prometheus metrics

2023/03/21 13:14:00 http: panic serving 127.0.0.1:46890: inconsistent label cardinality: expected 9 label values but got 10 in prometheus.Labels{"bkey":"BValue", "ckey":"CValue", "fd_name":"", "hostname":"falco-rkvpv", "k8s_ns_name":"falco1", "k8s_pod_name":"falco-rkvpv", "priority":"Notice", "proc_name":"bash", "rule":"Terminal shell in container", "user_name":"root"}

Which issue(s) this PR fixes:

Bug introduced by #420

Fixes #

Special notes for your reviewer:

Signed-off-by: Thomas Labarussias <issif_github@gadz.org>
@Issif Issif added this to the 2.28.0 milestone Mar 21, 2023
@Issif
Copy link
Member Author

Issif commented Mar 21, 2023

cc @Lowaiz

Signed-off-by: Thomas Labarussias <issif_github@gadz.org>
@poiana
Copy link

poiana commented Mar 21, 2023

LGTM label has been added.

Git tree hash: f255ea6c8cb1a4a8f60be3991dade0bd6a986322

@poiana
Copy link

poiana commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a773a5b into master Mar 21, 2023
@poiana poiana deleted the fix-cardinality-prom-labels branch March 21, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants