Fix the config options defaults for telegram: it has to start with Telegram instead of Slack #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
/area config
Hi. I tried to use Telegram as output and configured it through env variables like so:
But it didn't work. falcosidekick did receive events from falco, but it wasn't forwarded to the specified Telegram chat. I checked falcosidekick logs and noticed that the list of outputs reported at the startup was empty for some reason:
I found the original pull request that introduced Telegram support and noticed that the defaults for the config were set with the wrong prefix
Slack
instead ofTelegram
:https://github.com/falcosecurity/falcosidekick/pull/431/files#diff-0e426a43248661127a0c0ee115aef7a1093b635f8993b3f7ebb1dd9f05b8f249R419
I changed it locally then, rebuild falcosidekick, and Telegram output started to work:
I guess that setting
v.SetDefault
also affects proper env variables parsing? Since that's why the fix actually worked.