Prepare handlers for new inputs + Fix #49 (StatsD missing metrics) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Issif
commented
Nov 10, 2019
•
Issif
commented
- Fix issue Current StatsD implementation works only with DogStatsD #49 with incorrect StatsD events (tags are not allowed by classic protocol, only by DogStatsD)
- Add new output DogStatsD (issue Current StatsD implementation works only with DogStatsD #49)
- Add nex expvar metrics for number of running goroutines, number of used CPU, StatsD/DogStatsD Outputs
- Standardization of metric names (be consistent between expar and statsd)
- Handlers ready for new inputs (fifo, grpc)
- Consistant names for metrics between expvar/(dog)statsd
- Fix panic when payload from falco is empty
- Add dogstatsd/statsd in all clients
- Add @actgardner as helm chart maintainer
Fix issue #49 with incorrect StatsD events (tags are not allowed by classic protocol, only by DogStatsD) Add new output DogStatsD (issue #49) Add nex expvar metrics for number of running goroutines, number of used CPU, StatsD/DogStatsD Outputs Standardization of metric names (be consistent between expar and statsd) Add actgardner as helm chart maintainer
Issif
added
kind/bug
- ready for new inputs (fifo, grpc) - consistant names for metrics between expvar/statsd - fix panic when payload from falco is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.