feat(config/server): Add option to deploy a HTTP server for the metrics endpoint #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
size/M
dco-signoff: no
do-not-merge/contains-merge-commits
and removed
dco-signoff: yes
labels
annadorottya
force-pushed
the
add-separate-http-server-for-prometheus
branch
from
2de4d79
to
714e4bf
Compare
poiana
added
dco-signoff: yes
size/XS
and removed
dco-signoff: no
do-not-merge/contains-merge-commits
size/M
labels
…cs endpoint Signed-off-by: Anna Simon <asimon@mercari.com>
|
See my comment in #564, I don't think this implementation would be the best. |
… endpoints Signed-off-by: Anna Simon <asimon@mercari.com>
Issif
approved these changes
Jul 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: annadorottya, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 6e9ee53cc543f67e445792ec08799f8f255b25c5
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area config
What this PR does / why we need it: See issue
Which issue(s) this PR fixes:
Fixes #564
Special notes for your reviewer: