Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord output #61

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Discord output #61

merged 1 commit into from
Aug 2, 2020

Conversation

nibalizer
Copy link
Contributor

@nibalizer nibalizer commented May 6, 2020 •
edited
Loading

Added a discord output source. Ready for review!

@nibalizer nibalizer marked this pull request as draft May 6, 2020 22:27
Issif
Issif requested changes May 6, 2020
View reviewed changes
config.go Show resolved Hide resolved
Issif
Issif reviewed May 7, 2020
View reviewed changes
outputs/discord.go Outdated Show resolved Hide resolved
outputs/discord.go Outdated Show resolved Hide resolved
@Issif
Copy link
Member

Issif commented May 17, 2020

@nibalizer What about my proposal on Slack to format the output with colors, etc, like for Slack and others?

@nibalizer
Copy link
Contributor Author

Yes I think we should do it. I can work on this a bit today and will. Sorry for the delay.

@nibalizer
Copy link
Contributor Author

nibalizer commented May 18, 2020 •
edited
Loading

@Issif please see my note above, I don't see a good way to do colors for messages in discord.

@nibalizer
Copy link
Contributor Author

Color is working, need to write some more code before it'll work/look right

image

@nibalizer
Copy link
Contributor Author

Thanks for the tip @Issif

@Issif
Copy link
Member

Issif commented May 19, 2020

Nice ! Can you display fields as seperated? One again, like in Slack or Teams.

@leodido leodido added kind/feature New feature or request and removed new feature labels Jul 2, 2020
@leodido leodido closed this Jul 3, 2020
@leodido leodido reopened this Jul 3, 2020
leodido
leodido reviewed Jul 3, 2020
View reviewed changes
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nibalizer thanks for all you do! 🎉

I enabled @poiana here too, so you should sign-off (and maybe clean up a bit) the commit history of this PR.

@nibalizer
Copy link
Contributor Author

Sorry team! I'll try to get back to this as soon as I can!

@Issif
Copy link
Member

Issif commented Jul 28, 2020

@nibalizer no problem, I'm really busy on my side

@nibalizer nibalizer marked this pull request as ready for review July 29, 2020 02:58
Issif
Issif requested changes Jul 31, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@nibalizer @Issif
feat(discord): Add discord output
922b267 
Signed-off-by: Spencer Krum <nibz@spencerkrum.com>
Co-authored-by: Thomas Labarussias <issif+github@gadz.org>
@poiana poiana added the lgtm label Aug 2, 2020
@poiana
Copy link

poiana commented Aug 2, 2020

LGTM label has been added.

Git tree hash: cc879161305492236a796a8fff745563ace9ee31

@poiana poiana added the approved label Aug 2, 2020
@Issif
Copy link
Member

Issif commented Aug 2, 2020

/lgtm
/approve

@poiana
Copy link

poiana commented Aug 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8e133c3 into falcosecurity:master Aug 2, 2020
@Issif Issif added this to the 2.14.0 milestone Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodido leodido leodido left review comments

@Issif Issif Issif approved these changes

Assignees

@Issif Issif

Labels
approved dco-signoff: yes kind/feature New feature or request lgtm size/L
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nibalizer @Issif @poiana @leodido