-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quickwit_output): implement the quickwit output #736
feat(quickwit_output): implement the quickwit output #736
Conversation
Welcome @idrissneumann! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
310a07a
to
31e7a58
Compare
31e7a58
to
3fc81aa
Compare
3d7dfd1
to
f583b90
Compare
f583b90
to
309b1d1
Compare
fe20871
to
9b1d688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 1 thing to fix and we're good
50fd3f5
to
483054a
Compare
@Issif Thanks. Done for your last comment and tested again, still working fine: |
483054a
to
18a1ce4
Compare
18a1ce4
to
d85dc1e
Compare
c7cf633
to
82e6423
Compare
Record: "basic", | ||
Tokenizer: "raw", | ||
}, | ||
FieldMappings: []QuickwitFieldMapping{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw I think it'd be interesting to propose this feature (autocreate index with the mapping) for creating the Elasticsearch index, I can do that in a new PR too after this one :)
Yes sure, we just have the same issue with the output_fields
, I let you create the PR later.
Record: "basic", | ||
Tokenizer: "raw", | ||
}, | ||
FieldMappings: []QuickwitFieldMapping{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idrissneumann I notice the logs containing json are multi lines, can you use https://pkg.go.dev/encoding/json#Compact to minify them and have them on the same line please
Signed-off-by: Idriss Neumann <idriss.neumann@comwork.io>
82e6423
to
2e9f3f5
Compare
/lgtm |
LGTM label has been added. Git tree hash: 3e825a0c4cdb8f4ecb05220888d1e31dc6dbf281
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: idrissneumann, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #640
Special notes for your reviewer: