Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #780: duplicated headers #801

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix issue #780: duplicated headers #801

merged 1 commit into from
Feb 28, 2024

Conversation

Issif
Copy link
Member

@Issif Issif commented Feb 28, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Remove headers when the request to the output fails to avoid duplication

Which issue(s) this PR fixes:

#780

Fixes #

Special notes for your reviewer:

@Issif Issif added this to the 2.29.0 milestone Feb 28, 2024
@poiana poiana added dco-signoff: yes kind/bug Something isn't working labels Feb 28, 2024
@Issif Issif changed the title fix issue #780: deplicated headers fix issue #780: duplicated headers Feb 28, 2024
Signed-off-by: Thomas Labarussias <issif_github@gadz.org>
@poiana
Copy link

poiana commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Feb 28, 2024

LGTM label has been added.

Git tree hash: 6930969fdcae144095e85f378a81ecf52a12450c

@poiana poiana merged commit f42b5c0 into master Feb 28, 2024
5 checks passed
@poiana poiana deleted the fix-780 branch February 28, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants