Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the method to set the custom headers in the client.go #857

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

Issif
Copy link
Member

@Issif Issif commented Apr 24, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

change the method to set the custom headers in the client.go, it allows now to override the content-type

Which issue(s) this PR fixes:

#663
#856

Fixes #

Special notes for your reviewer:

…ws now to override the content-type

add warning for smtp and office365

improve notes and warning format

Signed-off-by: Thomas Labarussias <issif_github@gadz.org>
@poiana
Copy link

poiana commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Apr 25, 2024

LGTM label has been added.

Git tree hash: 85f0a441214230e8fd0106e91f73aaddedf2a595

@poiana poiana merged commit 80495c9 into master Apr 25, 2024
5 checks passed
@poiana poiana deleted the fix-856 branch April 25, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants