Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamp the policy reporter output #899

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

Issif
Copy link
Member

@Issif Issif commented May 21, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

The output was hard to extend or debug, I preferred to revamp it totally for readability.

Which issue(s) this PR fixes:

#803 #804

image

Fixes #

Special notes for your reviewer:

@Issif Issif added this to the 2.29.0 milestone May 21, 2024
@poiana poiana requested review from fjogeleit and leogr May 21, 2024 23:24
@Issif Issif force-pushed the feature/refactor-policy-reporter branch 2 times, most recently from 91ffc68 to 29e887f Compare May 28, 2024 12:58
@Issif Issif changed the title WIP: revamp the policy reporter output revamp the policy reporter output May 28, 2024
Signed-off-by: Thomas Labarussias <issif_github@gadz.org>
@Issif Issif force-pushed the feature/refactor-policy-reporter branch from 29e887f to 2888bdd Compare May 28, 2024 13:01
@poiana poiana added the lgtm label Jun 11, 2024
@poiana
Copy link

poiana commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fjogeleit, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jun 11, 2024

LGTM label has been added.

Git tree hash: 079ef1f43d1167ccf99de1326621e985e9105639

@poiana poiana merged commit 9b9f423 into master Jun 11, 2024
4 of 5 checks passed
@poiana poiana deleted the feature/refactor-policy-reporter branch June 11, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants