Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New output type: Webex #979

Merged
merged 1 commit into from
Sep 5, 2024
Merged

New output type: Webex #979

merged 1 commit into from
Sep 5, 2024

Conversation

k0rventen
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

This PR adds the 'Webex' output, enabling sending messages to a given Webex Room using a Webhook URL. As the format expected by the Webex API endpoint is very specific, using the Webhook output isn't possible.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I've taken inspiration from the Teams output, which is quite similar, which is why I placed the various Webex declarations right below it. If you prefer another order, let me know.

I've tested it sucessfully using the provided curls's tests commands, and a few falco rules of my own.
Also let me now if I missed some docs/example ?

Regards !

@poiana
Copy link

poiana commented Aug 27, 2024

Welcome @k0rventen! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/L label Aug 27, 2024
@k0rventen k0rventen force-pushed the master branch 2 times, most recently from 067c6e0 to df339a9 Compare August 27, 2024 21:04
@Issif Issif added this to the 2.30 milestone Aug 27, 2024
@Issif
Copy link
Member

Issif commented Aug 27, 2024

Amazing proposal, and it seems very complete. I will do the full review asap. Thanks

@Issif Issif self-assigned this Sep 2, 2024
@k0rventen
Copy link
Contributor Author

Amazing proposal, and it seems very complete. I will do the full review asap. Thanks

Hey thx ! I just pushed a few fixes, apparently I forgot to check if I changed 'teams' to 'webex' everywhere. Also an improvement on the template loading, which is now done only once instead of on every call of the post function (not a go expert but I think it's better ?)

Cheers !

config_example.yaml Outdated Show resolved Hide resolved
docs/outputs/webex.md Show resolved Hide resolved
docs/outputs/webex.md Outdated Show resolved Hide resolved
outputs/webex.go Outdated Show resolved Hide resolved
outputs/webex.go Outdated Show resolved Hide resolved
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also squash your commits once you fixed my comments, please

@k0rventen
Copy link
Contributor Author

could you also squash your commits once you fixed my comments, please

We should be good now !

@Issif
Copy link
Member

Issif commented Sep 2, 2024

could you also squash your commits once you fixed my comments, please

We should be good now !

Just the squash to do and I'll approve. Thanks

@k0rventen
Copy link
Contributor Author

k0rventen commented Sep 2, 2024

could you also squash your commits once you fixed my comments, please

We should be good now !

Just the squash to do and I'll approve. Thanks

yeah sorry when squashing I rewrote the commit message, leading to this one: 0db1a5f

@Issif
Copy link
Member

Issif commented Sep 3, 2024

could you also squash your commits once you fixed my comments, please

We should be good now !

Just the squash to do and I'll approve. Thanks

yeah sorry when squashing I rewrote the commit message, leading to this one: 0db1a5f

the 6 commits are still there, most of them are typo fixes, rebase on the master then squash (rebase -i) your commits on the HEAD/master please

@k0rventen
Copy link
Contributor Author

it's now all in 19a6aac 😄

docs/outputs/webex.md Outdated Show resolved Hide resolved
outputs/webex.go Outdated Show resolved Hide resolved
Signed-off-by: k0rventen <49311792+k0rventen@users.noreply.github.com>
@poiana poiana added the lgtm label Sep 3, 2024
@poiana
Copy link

poiana commented Sep 3, 2024

LGTM label has been added.

Git tree hash: d1c1e171724ca70bd871d06c25f03d8858aa0e9c

@poiana
Copy link

poiana commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, k0rventen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Sep 3, 2024
@poiana poiana merged commit 45f6cb7 into falcosecurity:master Sep 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants