-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New output type: Webex #979
Conversation
Welcome @k0rventen! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
067c6e0
to
df339a9
Compare
Amazing proposal, and it seems very complete. I will do the full review asap. Thanks |
Hey thx ! I just pushed a few fixes, apparently I forgot to check if I changed 'teams' to 'webex' everywhere. Also an improvement on the template loading, which is now done only once instead of on every call of the post function (not a go expert but I think it's better ?) Cheers ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also squash your commits once you fixed my comments, please
We should be good now ! |
Just the squash to do and I'll approve. Thanks |
yeah sorry when squashing I rewrote the commit message, leading to this one: 0db1a5f |
the 6 commits are still there, most of them are typo fixes, rebase on the master then squash (rebase -i) your commits on the HEAD/master please |
cc6f85a
to
19a6aac
Compare
it's now all in 19a6aac 😄 |
Signed-off-by: k0rventen <49311792+k0rventen@users.noreply.github.com>
LGTM label has been added. Git tree hash: d1c1e171724ca70bd871d06c25f03d8858aa0e9c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, k0rventen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This PR adds the 'Webex' output, enabling sending messages to a given Webex Room using a Webhook URL. As the format expected by the Webex API endpoint is very specific, using the Webhook output isn't possible.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I've taken inspiration from the Teams output, which is quite similar, which is why I placed the various Webex declarations right below it. If you prefer another order, let me know.
I've tested it sucessfully using the provided curls's tests commands, and a few falco rules of my own.
Also let me now if I missed some docs/example ?
Regards !