[Elasticsearch] Add Pipeline configuration #981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
Adds configurable ingest pipeline for Elasticsearch output. For more documentation refer to: https://www.elastic.co/guide/en/elasticsearch/reference/current/ingest.html
This is super useful when users need to specify the ingest pipeline for the data transformation.
Special notes for your reviewer:
Added one
FIXME:
comment https://github.com/falcosecurity/falcosidekick/pull/981/files#diff-63512941b06c3ecd46ca56b6745027a3d30b9ff012c5e1e9d1508ee4e22df39fR102.There is a potential race condition when
c.EndpointURL
gets set in the output request sending code, since this is a member variable that can be accessed from multiple go routines. I fixed this for Elasticsearch output, and noticed another place in Sumologic output https://github.com/falcosecurity/falcosidekick/blob/master/outputs/sumologic.go#L24I can look at addressing that
FIXME
if I have time later to avoid the similar mistakes in other outputs.