fix(kernel_crawler): support debian rpi. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
|
We are finding no headers for |
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
fix/debian_rpi
branch
from
f88b68c
to
d337b01
Compare
FedeDP
commented
Dec 15, 2023
| print(line) | ||
| raise | ||
| # Just skip the line if it is malformed | ||
| continue |
There was a problem hiding this comment.
Malformed lines can happen; in my tests, a line Description: was breaking this. Just skip it.
FedeDP
commented
Dec 15, 2023
| @@ -31,6 +31,7 @@ def __init__(self, arch): | |||
| mirrors = [ | |||
| deb.DebMirror('http://mirrors.edge.kernel.org/debian/', arch, repo_filter), | |||
| deb.DebMirror('http://security.debian.org/', arch, repo_filter), | |||
| deb.DebMirror('http://archive.raspberrypi.com/debian/', arch, repo_filter), | |||
There was a problem hiding this comment.
Debian mirror for raspberrypi.
FedeDP
commented
Dec 15, 2023
| @@ -58,7 +59,8 @@ def to_driverkit_config(self, release, deps): | |||
| headers = [] | |||
| headers_rt = [] | |||
| headers_cloud = [] | |||
| # Magic to obtain `rt`, `cloud` and normal headers: | |||
| headers_rpi = [] | |||
There was a problem hiding this comment.
Logic to handle headers for rpi.
FedeDP
commented
Dec 15, 2023
| return [repo.DriverKitConfig(release + "-" + self.arch, "debian", headers), | ||
| repo.DriverKitConfig(release + "-rt-" + self.arch, "debian", headers_rt), | ||
| repo.DriverKitConfig(release + "-cloud-" + self.arch, "debian", headers_cloud)] | ||
| final = [] |
There was a problem hiding this comment.
We only add headers for which we found at least 3 packages.
FedeDP
commented
Dec 15, 2023
| content = get_url(url) | ||
| # If content is None and we got elements after this one, | ||
| # try the next ones. | ||
| if content is not None or idx == len(urls) - 1: |
There was a problem hiding this comment.
If get_url returns None content, try the next one instead of returning None.
|
/cc @EXONER4TED |
|
/cc @leogr |
|
Crawled rpi kernels: |
leogr
approved these changes
Dec 15, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area crawler
What this PR does / why we need it:
Add support for debian rpi kernels.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: