Skip to content

Commit

Permalink
Add unit test that verifies fix for binary_check_expr::is_equal
Browse files Browse the repository at this point in the history
Create two expressions with the same lhs/rhs but different ops, and
ensure that is_equal() returns false.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
  • Loading branch information
mstemm authored and poiana committed Jul 11, 2024
1 parent 5a84ab4 commit d8b5b2e
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 0 deletions.
1 change: 1 addition & 0 deletions userspace/libsinsp/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ endif()
file(GLOB_RECURSE TEST_HELPERS ${CMAKE_CURRENT_SOURCE_DIR}/helpers/*.cpp)

set(LIBSINSP_UNIT_TESTS_SOURCES
ast_exprs.ut.cpp
test_utils.cpp
sinsp_with_test_input.cpp
cgroup_list_counter.ut.cpp
Expand Down
38 changes: 38 additions & 0 deletions userspace/libsinsp/test/ast_exprs.ut.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// SPDX-License-Identifier: Apache-2.0
/*
Copyright (C) 2024 The Falco Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

#include <libsinsp/filter/parser.h>
#include <gtest/gtest.h>

using namespace libsinsp::filter::ast;

static std::unique_ptr<expr> make_expr(const std::string& cond)
{
libsinsp::filter::parser p(cond);

std::unique_ptr<expr> e = p.parse();

return e;
}

TEST(ast, compare_binary_check_exprs)
{
std::unique_ptr<expr> e1 = make_expr("evt.num >= 0");
std::unique_ptr<expr> e2 = make_expr("evt.num = 0");
ASSERT_FALSE(e1->is_equal(e2.get()));
}

0 comments on commit d8b5b2e

Please sign in to comment.