Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: build: basic CI configuration #11

Closed
wants to merge 1 commit into from
Closed

Conversation

leogr
Copy link
Member

@leogr leogr commented Feb 24, 2021

This is a temporary setup that aims to test the building system and run unit tests. Inspired by https://github.com/falcosecurity/falco/blob/master/.circleci/config.yml

Signed-off-by: Leonardo Grasso me@leonardograsso.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Temporary solution for #9, though not completely fix it.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


This is a temporary setup that aims to test the building system and run unit tests. Inspired by https://github.com/falcosecurity/falco/blob/master/.circleci/config.yml

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@poiana
Copy link
Contributor

poiana commented Feb 24, 2021

@leogr: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Feb 24, 2021

@leogr: The label(s) area/build cannot be applied, because the repository doesn't have them

In response to this:

This is a temporary setup that aims to test the building system and run unit tests. Inspired by https://github.com/falcosecurity/falco/blob/master/.circleci/config.yml

Signed-off-by: Leonardo Grasso me@leonardograsso.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

What this PR does / why we need it:

Which issue(s) this PR fixes:

Temporary solution for #9, though not completely fix it.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Feb 24, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign leogr after the PR has been reviewed.
You can assign the PR to them by writing /assign @leogr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the size/M label Feb 24, 2021
@leogr
Copy link
Member Author

leogr commented Feb 24, 2021

As discussed privately with @leodido , we have decided to abandon this approach in favor of a prow job implementation.
See falcosecurity/test-infra#319
/close

@poiana poiana closed this Feb 24, 2021
@poiana
Copy link
Contributor

poiana commented Feb 24, 2021

@leogr: Closed this PR.

In response to this:

As discussed privately with @leodido , we have decided to abandon this approach in favor of a prow job implementation.
See falcosecurity/test-infra#319
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants