-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: Modernize C++ struct/enum/union declarations #1588
cleanup: Modernize C++ struct/enum/union declarations #1588
Conversation
3b327b7
to
7a75825
Compare
Same, could we get a rebase, thanks! |
7a75825
to
c76d944
Compare
@incertum Thanks for the nudge. Done. |
c76d944
to
d3a5d92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: f2ce7af701eaaa3883a23a844e7293bc31643960
|
Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
cd3e9d2
d3a5d92
to
cd3e9d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: f2a0e4a125439bb5ee2fe0fbf7bd2b33ae83586c
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, federico-sysdig, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
Does this PR require a change in the driver versions?
no
What this PR does / why we need it:
From the
falcosecurity/libs
project's coding guidelines:This PR changes
struct
/union
/enum
definitions to follow just that.Also, it changes declarations of objects of struct/union/enum type as to remove the
struct
/union
/enum
in the C++ code as user-defined types are "first-class citizens" in C++ and don't need a special, longer, syntax.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The changes are very many, but consider that they are all instances of the same change. For instance
struct sinsp_chisel* ch;
becomessinsp_chisel* ch;
. Apart the mechanical change, there is no difficult logic to be reviewed in this PR.Does this PR introduce a user-facing change?: