fix(userspace/libsinsp): fix resolved PT_FSPATH and PT_FSRELPATH evt params #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…args Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
poiana
added
release-note
dco-signoff: yes
kind/bug
LucaGuerra
approved these changes
Dec 20, 2023
|
LGTM label has been added. Git tree hash: 585f3ed062d098d39ce1baac1c9e083c476525e5
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @Andreagit97 0.14.1? |
|
/milestone 0.14.1 |
This was referenced Jan 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
This fixes a minor bug introduced in #1533 and affecting event params of type
PT_FSPATHandPT_FSRELPATH. The issue involves wrong path resolutions insinsp_evt::get_param_as_strthat can cause the returned value to contain the resolved absolute path instead of the relative one even when not desired.Special notes for your reviewer:
Does this PR introduce a user-facing change?: