Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(libscap/kmod): remove ASSERT(false) on handled errors #1603

Merged

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Dec 22, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libscap-engine-kmod

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

These ASSERTS() look redundant since each error that they precede is handled and would make the program crash with a meaningful error either way. In addition, one test is actually throwing an error on purpose and may trigger one of these assert, aborting the test suite

Note: Google Test filter = sinsp.wrong_host_root
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from sinsp
[ RUN      ] sinsp.wrong_host_root
unit-test-libsinsp: /home/ubuntu/dev/falcosecurity/libs/userspace/libscap/engine/kmod/scap_kmod.c:171: mark_syscall: Assertion `0' failed.
Aborted

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra changed the title fix(libscap): remove ASSERT(false) on handled errors cleanup(libscap/kmod): remove ASSERT(false) on handled errors Dec 22, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 22, 2023

LGTM label has been added.

Git tree hash: d6f0fc2ec3c661b5778871740fe20cfaeacfc7ce

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97 Andreagit97 added this to the 0.14.1 milestone Dec 22, 2023
@poiana poiana merged commit e9333d9 into falcosecurity:master Dec 22, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants