-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add new cgroup layout for podman #1613
fix: Add new cgroup layout for podman #1613
Conversation
Signed-off-by: Matthew Knight <matthew.knight@sysdig.com>
7b3e7c3
to
8a4ff3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 889ef95209ac305a5f6b766b3054fc3f76bcf307
|
/milestone 0.14.1 |
/approve |
@gnosek missing github approve 😆 |
oh @poiana how I hate thee |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, gnosek, mattnite The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
I'm finding podman cgroup names that are suffixed with
/container
, and because we don't handle this layout pattern, processes in podman containers are being seen as running on the host. This is seen when investigating SCAP files. This patch adds this layout to the list. For example here's some output fromsystemd-cgls
:Special notes for your reviewer:
Does this PR introduce a user-facing change?: