fix(cmake): reintroduce -Werror with BUILD_WARNINGS_AS_ERRORS #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Guerra <luca@guerra.sh>
poiana
added
release-note-none
kind/bug
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
incertum
approved these changes
Jan 11, 2024
|
LGTM label has been added. Git tree hash: 115dbbae3019e78e8667bfb496d7e9f80a34a684
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.14.1 |
|
Yes thanks for agreeing with 0.14.1, by including it there we have warnings as errors in CI for the changes we publish to the release branch so it's beneficial I think! |
This was referenced Jan 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR adds
-Werrorto make theBUILD_WARNINGS_AS_ERRORSoptions work again. As you can see, we now attempt to enable that via CMAKE_COMPILE_WARNING_AS_ERROR but that option requires CMake 3.24 and we use 3.13 in CI.Also, fix resulting warnings.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: