Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libsinsp): modify switch case #1620

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

ecbadeaux
Copy link
Contributor

@ecbadeaux ecbadeaux commented Jan 14, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area libsinsp

Does this PR require a change in the driver versions?

I am not sure about this.

What this PR does / why we need it:

@dwindsor @incertum
Noticed this while working on another issue. Shouldn't this be using the PPM socket type like the rest of the socket types in this "if/else if" case statement. You can see we are using PPM_AF_INET6 & PPM_AF_INET, so why are we not using the PPM_AF_UNIX def?

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Everett Badeaux <everettc1810@gmail.com>
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Makes sense, luckily they resolve to the same value, so it's not an urgent issue.

@poiana
Copy link
Contributor

poiana commented Jan 14, 2024

LGTM label has been added.

Git tree hash: 40fa9550762df80583b2d09124b58fa6c28d2aa1

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch! Thank you!
/approve

@poiana
Copy link
Contributor

poiana commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecbadeaux, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Jan 15, 2024

/milestone 0.14.1
I think this is a small yet important fix for 0.14.1

@poiana poiana added this to the 0.14.1 milestone Jan 15, 2024
@poiana poiana merged commit b993f6d into falcosecurity:master Jan 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants