Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fixed build using external modern bpf skeleton + added drivers_ci job to test it #1641

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 24, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build
/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

2 commits:

  • the first commit adds a drivers_ci job to check that the extenral build of the modern bpf skel object, and its subsequent injection in a follow up job to build scap-open, works. This is what is being done in Falco CI and reusable_kernel_tests.
  • the second one fixes a recent regression preventing us from building: fix(pman): missing probe skeleton header file #1624

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana requested review from hbrueckner and leogr January 24, 2024 07:47
@FedeDP FedeDP force-pushed the fix/modern_bpf_extenral_skeleton branch from 3586e07 to d4e36f2 Compare January 24, 2024 07:57
@poiana poiana added size/L and removed size/M labels Jan 24, 2024
@FedeDP FedeDP force-pushed the fix/modern_bpf_extenral_skeleton branch 2 times, most recently from fa20a16 to 573a3ce Compare January 24, 2024 08:04
…ap-open build (like kernel tests and Falco do).

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
…s a target.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the fix/modern_bpf_extenral_skeleton branch from 0960497 to 7585cf3 Compare January 24, 2024 08:15
@FedeDP FedeDP changed the title wip: new(ci): added drivers_ci job to test external modern_bpf skeleton scap-open build new(ci): added drivers_ci job to test external modern_bpf skeleton scap-open build Jan 24, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 24, 2024

/milestone 0.15.0

@poiana poiana added this to the 0.15.0 milestone Jan 24, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 24, 2024

@federico-sysdig PTAL :)

@FedeDP FedeDP changed the title new(ci): added drivers_ci job to test external modern_bpf skeleton scap-open build fix(ci): fixed build using external modern bpf skeleton + added drivers_ci job to test it Jan 24, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit eb7233a into master Jan 24, 2024
32 of 33 checks passed
@poiana poiana deleted the fix/modern_bpf_extenral_skeleton branch January 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants