Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver/bpf): decrease limits to support some GKE env #1642

Merged
merged 1 commit into from
Jan 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions driver/bpf/fillers.h
Original file line number Diff line number Diff line change
Expand Up @@ -5044,10 +5044,13 @@ FILLER(sched_drop, false)
return bpf_push_u32_to_ring(data, data->settings->sampling_ratio);
}

/* In this kernel version the instruction limit was bumped to 1000000 */
/* In this kernel version the instruction limit was bumped to 1000000.
* We use these 2 values because they are the minimum required to run our eBPF probe
* on some GKE environments. See https://github.com/falcosecurity/libs/issues/1639
*/
#if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 2, 0))
#define MAX_THREADS_GROUPS 30
#define MAX_HIERARCHY_TRAVERSE 60
#define MAX_THREADS_GROUPS 25
#define MAX_HIERARCHY_TRAVERSE 35
#else
/* We need to find the right calibration here. On kernel 4.14 the limit
* seems to be MAX_THREADS_GROUPS*MAX_HIERARCHY_TRAVERSE <= 100
Expand Down