fix(libsinsp): avoid setting a null event pointer when returning SCAP… #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
FedeDP
reviewed
Mar 8, 2024
userspace/libsinsp/sinsp.cpp
Outdated
| @@ -1202,8 +1202,9 @@ int32_t sinsp::next(OUT sinsp_evt **puevt) | |||
| { | |||
| if (m_external_event_processor) | |||
| { | |||
| m_external_event_processor->process_event(NULL, libsinsp::EVENT_RETURN_EOF); | |||
| m_external_event_processor->process_event(evt, libsinsp::EVENT_RETURN_EOF); | |||
There was a problem hiding this comment.
#1423 didn't touch these lines? I see that this code is there since ~3yrs at least; a quick blame showed that: https://github.com/falcosecurity/libs/blame/682a4a9ea917dabff8df75bd739ee446a940251e/userspace/libsinsp/sinsp.cpp
There was a problem hiding this comment.
You're right. That's not needed.
mrgian
force-pushed
the
fix-null-ptr-scap-eof
branch
from
0bd6330 to
fadaa42
Compare
…_EOF in sinsp::next Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
mrgian
force-pushed
the
fix-null-ptr-scap-eof
branch
from
fadaa42 to
883b4aa
Compare
|
LGTM label has been added. Git tree hash: bf76dcd738c7e95f64556604ff81ca8805291db6
|
|
/milestone 0.15.0 |
jasondellaluce
approved these changes
Mar 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_EOF in sinsp::next
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Avoids a possible segfault in applications expecting a valid event pointer when
SCAP_EOFis reached (e.g. oss-sysdig),like it was before #1423 .
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: