Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test/libsinsp_e2e): use unique ptr e2e tests inspector #1754

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Mar 18, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area tests

What this PR does / why we need it:

Also, this fixes recent CI issues; see actions/runner-images#9524 and actions/runner-images#9491.

Which issue(s) this PR fixes:

Fixes #1750

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP added 2 commits March 18, 2024 15:19
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
See actions/runner-images#9524 (comment) for the fix.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 18, 2024

/milestone 0.16.0

@poiana poiana added this to the 0.16.0 milestone Mar 18, 2024
@poiana poiana added the size/M label Mar 18, 2024
@@ -79,7 +79,6 @@ void event_capture::capture()
m_capture_started = true;
m_condition_started.notify_one();
}
delete m_inspector;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to delete unique ptr anymore.
Also, sinsp dtor autoamtically calls stop capture and scap_close for us.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cce37fa into master Mar 18, 2024
41 checks passed
@poiana poiana deleted the chore/use_unique_ptr_e2e_tests_inspector branch March 18, 2024 16:58
This was referenced Mar 18, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 19, 2024

/milestone 0.15.1
since this is needed to fix ci.

@poiana poiana modified the milestones: 0.16.0, 0.15.1 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI asan jobs failures
4 participants