Don't drop events while requesting CPU usage from driver #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every second, we request per-process CPU usage from the driver which generates a stream of sinsp meta events. Unfortunately, whenever we do this, we drop the event we have received from scap_next just before we decided to get the CPU usage data. This patch moves the logic to a separate method, where an early return does not prevent handling the received event. Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
No functional changes expected Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
The code for eBPF gets CPU usage for individual threads from /proc. We can reuse it for the udig case as well. Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
Even though we don't currently support macOS instrumentation, not having this struct definition causes compilation warnings. Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
poiana
added
kind/bug
fntlnz
approved these changes
Mar 24, 2021
|
LGTM label has been added. Git tree hash: 3eedd39a96c04a939274b22df99bbe4e19195cae
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-ebpf
/area libscap
What this PR does / why we need it:
Every second, we request per-process CPU usage from the driver which generates a stream of sinsp meta events. Unfortunately, whenever we do this, we drop the event we have received from scap_next just before we decided to get the CPU usage data.
This patch moves the logic to a separate method, where an early return does not prevent handling the received event.
Special notes for your reviewer:
This is draios/sysdig#1685 resubmitted
The first commit is required for the fix, 2-3 are minor cleanups, 4-6 (as a whole) are nice to have, unifying CPU usage reporting across udig/eBPF backends
Does this PR introduce a user-facing change?: