-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: introduce proc.{stdin,stdout,stderr}.{name,type}
fields
#1916
Conversation
…in,stdout,stderr types Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
….fd fields Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
…elds Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
proc.fd.{stdin,stdout,stderr}.{name,type}
fieldsproc.{stdin,stdout,stderr}.{name,type}
fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 266f92b058a3a2b27b7a4dc6b23bcce44509c895
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, loresuso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Please check the motivations for this PR in #1894
If we all agree on this direction, my call is to start a deprecation process for
fd.types
because:fd.types
used as output field is useless, given that it returns an unordered list of typesname
part allow us for better detection and actionability (e.g in case of rev shell we see the connection tuple, in case of shell redirection to file the file itself and so on)Curious to get your feedback!
(example condition for rev shells:
evt.type=execve and evt.dir=< and proc.stdin.type=ipv4 and proc.name contains bash
)Which issue(s) this PR fixes:
Fixes #1894
Special notes for your reviewer:
Does this PR introduce a user-facing change?: