fix(sinsp): invalid threads shoudln't be in a pid namespace #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note-none
kind/bug
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Andreagit97
force-pushed
the
fix_invalid_threadinfo
branch
from
1bd5782 to
e8dae17
Compare
Perf diff from master |
1 similar comment
Perf diff from master |
|
LGTM label has been added. Git tree hash: 85975d141adb8c19e2b58dea6e60d56a448cbf24
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Andreagit97
added a commit
to Andreagit97/testing
that referenced
this pull request
Jun 25, 2024
ref libs PR: falcosecurity/libs#1923 Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
poiana
pushed a commit
to falcosecurity/testing
that referenced
this pull request
Jun 25, 2024
ref libs PR: falcosecurity/libs#1923 Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
|
/milestone 0.17.3 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
When a thread is "invalid" it has a
vtid = -1so when we checkm_tid != m_vtidinis_in_pid_namespacewe will always return true. we need to perform the check only if both identifiers are validWhich issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: