new(scap, sinsp)!: linux_hostinfo platform for use with non-syscall source plugins #1969

gnosek · 2024-07-22T06:13:57Z

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Introduce a new lightweight Linux platform type and expose it for use with (non-syscall) source plugins

Which issue(s) this PR fixes:

Fixes #2821

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(scap, sinsp): linux_hostinfo platform for use with non-syscall source plugins
new(sinsp)!: sinsp::open_plugin now takes a sinsp_plugin_platform instead of sinsp_mode_t

github-actions · 2024-07-22T06:22:30Z

Perf diff from master - unit tests

    10.28%     +1.23%  [.] sinsp_parser::reset
     5.21%     -1.08%  [.] sinsp_parser::process_event
     2.06%     +0.65%  [.] scap_event_decode_params
     5.19%     -0.64%  [.] next
     3.48%     +0.61%  [.] gzfile_read
     4.05%     +0.60%  [.] sinsp_evt::load_params
     1.75%     -0.59%  [.] libsinsp::sinsp_suppress::process_event
     7.26%     -0.58%  [.] sinsp::next
     1.48%     -0.51%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     1.90%     -0.48%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node

Perf diff from master - scap file

     3.25%     +9.48%  [.] sinsp_evt_formatter::tostring_withformat
    10.70%     -5.24%  [.] sinsp::next
    12.61%     -5.07%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     9.76%     -4.66%  [.] sinsp_filter_check::tostring
     9.40%     -4.42%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     6.86%     -2.84%  [.] sinsp_filter_check::apply_transformers
     3.25%     +2.36%  [.] sinsp_evt::get_type
    14.04%     -1.43%  [.] sinsp_filter_check::extract_nocache
     4.05%     -1.11%  [.] sinsp_parser::process_event
     3.25%     +0.90%  [.] sinsp_filter_check::get_transformed_field_info

Heap diff from master - unit tests

total runtime: -0.01s.
calls to allocation functions: -233 (33285/s)
temporary memory allocations: -98 (14000/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.002000s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 0 (0/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-22T06:29:04Z

Perf diff from master - unit tests

     4.84%     +0.81%  [.] sinsp_evt::get_type
     5.10%     -0.79%  [.] sinsp_parser::process_event
     2.72%     +0.75%  [.] sinsp_thread_manager::get_thread_ref
     1.71%     -0.61%  [.] libsinsp::sinsp_suppress::process_event
     0.75%     -0.45%  [.] scap_event_has_large_payload
     0.52%     -0.44%  [.] libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::dynamic_fields_t::dynamic_fields_t
     3.97%     +0.43%  [.] sinsp_evt::load_params
     1.30%     -0.42%  [.] sinsp_threadinfo::~sinsp_threadinfo
     1.11%     -0.39%  [.] sinsp_parser::event_cleanup
     3.29%     -0.37%  [.] sinsp_thread_manager::find_thread

Perf diff from master - scap file

     6.70%     +5.58%  [.] sinsp_evt_formatter::tostring_withformat
     6.52%     +3.23%  [.] gzfile_read
    17.30%     -2.88%  [.] 0x00000000000a76c4
    28.92%     +1.89%  [.] sinsp_filter_check::extract_nocache
    13.83%     +0.63%  [.] sinsp_filter_check::rawval_to_string
     6.69%     +0.49%  [.] sinsp_threadinfo::~sinsp_threadinfo
     6.65%     +0.47%  [.] libsinsp::container_engine::podman::resolve
     6.69%     +0.47%  [.] formatted_dump
     6.69%     +0.39%  [.] sinsp_filter_check::get_transformed_field_info

Heap diff from master - unit tests

total runtime: 0.05s.
calls to allocation functions: 977 (20787/s)
temporary memory allocations: 411 (8744/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: 0.00s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: -1 (-250/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

codecov · 2024-07-22T06:36:13Z

Codecov Report

Attention: Patch coverage is 64.70588% with 12 lines in your changes missing coverage. Please review.

Project coverage is 50.99%. Comparing base (3ce0a2d) to head (2118fcd).
Report is 38 commits behind head on master.

Files	Patch %	Lines
...space/libscap/linux/scap_linux_hostinfo_platform.c	68.75%	2 Missing and 3 partials ⚠️
userspace/libsinsp/sinsp.cpp	64.28%	5 Missing ⚠️
userspace/libsinsp/test/plugins.ut.cpp	50.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1969      +/-   ##
==========================================
+ Coverage   50.98%   50.99%   +0.01%     
==========================================
  Files         310      311       +1     
  Lines       39612    39636      +24     
  Branches    17793    17415     -378     
==========================================
+ Hits        20197    20214      +17     
+ Misses      14350    14328      -22     
- Partials     5065     5094      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-07-22T06:49:55Z

Perf diff from master - unit tests

     4.87%     +0.91%  [.] sinsp_evt::get_type
     3.43%     +0.83%  [.] gzfile_read
    10.13%     +0.81%  [.] sinsp_parser::reset
     3.79%     -0.72%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     5.13%     -0.70%  [.] sinsp_parser::process_event
     1.72%     -0.59%  [.] libsinsp::sinsp_suppress::process_event
     2.03%     -0.58%  [.] scap_event_decode_params
     1.55%     -0.49%  [.] 0x00000000000e83b0
     3.99%     -0.47%  [.] sinsp_evt::load_params
     0.48%     +0.42%  [.] libsinsp::state::stl_container_table_adapter<std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::dynamic_fields_t>::stl_container_table_adapter

Perf diff from master - scap file

     4.02%     +9.91%  [.] sinsp_evt_formatter::tostring_withformat
    15.61%     -3.98%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
    11.64%     -2.20%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
    12.08%     -1.62%  [.] sinsp_filter_check::tostring
     5.87%     -0.99%  [.] sinsp_evt::get_category
     5.02%     -0.56%  [.] sinsp_parser::process_event
     8.31%     +0.45%  [.] sinsp_filter_check::rawval_to_string
    17.37%     +0.37%  [.] sinsp_filter_check::extract_nocache
     4.02%     -0.06%  [.] sinsp_evt::get_type
     4.02%     -0.06%  [.] sinsp_thread_manager::get_thread_ref

Heap diff from master - unit tests

total runtime: -0.03s.
calls to allocation functions: 967 (-38680/s)
temporary memory allocations: 371 (-14840/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.01s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: -1 (125/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-22T06:56:01Z

Perf diff from master - unit tests

    10.27%     +1.54%  [.] sinsp_parser::reset
     5.21%     -1.41%  [.] sinsp_parser::process_event
     5.19%     -1.14%  [.] next
     7.26%     -0.92%  [.] sinsp::next
     4.94%     +0.88%  [.] sinsp_evt::get_type
     1.75%     -0.61%  [.] libsinsp::sinsp_suppress::process_event
     0.31%     +0.50%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find
     3.48%     +0.47%  [.] gzfile_read
     0.93%     -0.46%  [.] scap_next
     2.77%     -0.42%  [.] sinsp_thread_manager::get_thread_ref

Perf diff from master - scap file

     4.65%     +6.50%  [.] sinsp_evt_formatter::tostring_withformat
    15.31%     -4.57%  [.] sinsp::next
    20.08%     +4.14%  [.] sinsp_filter_check::extract_nocache
    13.96%     -4.01%  [.] sinsp_filter_check::tostring
    12.01%     -3.40%  [.] 0x00000000000a76c4
     4.65%     +2.23%  [.] next
     4.65%     +2.16%  [.] sinsp_threadinfo::~sinsp_threadinfo
     9.60%     -2.07%  [.] sinsp_filter_check::rawval_to_string
     5.80%     +1.69%  [.] sinsp_parser::process_event
     4.65%     +0.10%  [.] sinsp_evt::get_type

Heap diff from master - unit tests

total runtime: 0.01s.
calls to allocation functions: 590 (49166/s)
temporary memory allocations: 362 (30166/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: 0.00s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 9 (2250/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-22T07:20:28Z

Perf diff from master - unit tests

     4.94%     +1.02%  [.] sinsp_evt::get_type
     5.22%     -1.00%  [.] sinsp_parser::process_event
     5.20%     +0.88%  [.] next
     3.85%     +0.63%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     3.48%     +0.59%  [.] gzfile_read
     1.75%     -0.52%  [.] libsinsp::sinsp_suppress::process_event
     2.12%     -0.52%  [.] sinsp::fetch_next_event
     0.31%     +0.45%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find
     0.65%     -0.40%  [.] scap_file_test_helpers::capture_search_evt_by_num
     0.93%     -0.36%  [.] scap_next

Perf diff from master - scap file

     4.75%     +8.30%  [.] next
     4.76%     +5.61%  [.] sinsp_evt_formatter::tostring_withformat
     4.76%     +5.51%  [.] sinsp_thread_manager::get_thread_ref
    13.76%     -3.68%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     4.76%     +3.14%  [.] sinsp_thread_manager::find_thread
    12.28%     -2.66%  [.] 0x00000000000a76c4
     9.82%     -1.64%  [.] sinsp_filter_check::rawval_to_string
    20.54%     -1.19%  [.] sinsp_filter_check::extract_nocache
    15.66%     +0.94%  [.] sinsp::next
     4.16%     +0.56%  [.] sinsp::on_new_entry_from_proc

Heap diff from master - unit tests

total runtime: -0.06s.
calls to allocation functions: -829 (12953/s)
temporary memory allocations: -114 (1781/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.07s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 1 (-15/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

github-actions · 2024-07-22T09:10:14Z

Perf diff from master - unit tests

     4.94%     +1.02%  [.] sinsp_evt::get_type
     5.22%     -1.00%  [.] sinsp_parser::process_event
     5.20%     +0.88%  [.] next
     3.85%     +0.63%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     3.48%     +0.59%  [.] gzfile_read
     1.75%     -0.52%  [.] libsinsp::sinsp_suppress::process_event
     2.12%     -0.52%  [.] sinsp::fetch_next_event
     0.31%     +0.45%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find
     0.65%     -0.40%  [.] scap_file_test_helpers::capture_search_evt_by_num
     0.93%     -0.36%  [.] scap_next

Perf diff from master - scap file

     4.75%     +8.30%  [.] next
     4.76%     +5.61%  [.] sinsp_evt_formatter::tostring_withformat
     4.76%     +5.51%  [.] sinsp_thread_manager::get_thread_ref
    13.76%     -3.68%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     4.76%     +3.14%  [.] sinsp_thread_manager::find_thread
    12.28%     -2.66%  [.] 0x00000000000a76c4
     9.82%     -1.64%  [.] sinsp_filter_check::rawval_to_string
    20.54%     -1.19%  [.] sinsp_filter_check::extract_nocache
    15.66%     +0.94%  [.] sinsp::next
     4.16%     +0.56%  [.] sinsp::on_new_entry_from_proc

Heap diff from master - unit tests

total runtime: -0.06s.
calls to allocation functions: -829 (12953/s)
temporary memory allocations: -114 (1781/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.07s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 1 (-15/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

incertum · 2024-07-22T16:52:13Z

Just need to decide on the naming of the enum items, else LGTM ty!

FedeDP · 2024-07-31T07:31:33Z

userspace/libsinsp/sinsp.h

+enum class sinsp_plugin_platform
+{
+	GENERIC, //!< generic platform, no system information collected
+	LINUX_HOSTINFO, //!< basic host information collected, for non-syscall source plugins
+	LINUX, //!< full system information collected, for syscall source plugins
+};


Suggested change

enum class sinsp_plugin_platform

{

GENERIC, //!< generic platform, no system information collected

LINUX_HOSTINFO, //!< basic host information collected, for non-syscall source plugins

LINUX, //!< full system information collected, for syscall source plugins

};

enum class sinsp_plugin_platform

{

SINSP_PLATFORM_GENERIC, //!< generic platform, no system information collected

SINSP_PLATFORM_HOSTINFO, //!< basic host information collected, for non-syscall source plugins

SINSP_PLATFORM_FULL, //!< full system information collected, for syscall source plugins

};

Are we ok with this naming?

I sure am, though I thought we wanted to hide the platform concept from users?

Personally, I'd leave the thing as is (modulo naming), including the breaking API change but I'll accept whatever we decide.

I went this road :)

ok if it's now ok to say platform works for me for sure.

Why is it that I always push first, commit second? :D the enum variants should be renamed now

If the end result works, no problem :) Where are we at with this PR @gnosek? Ready for final review? Doesn't seem like any more folks posted on the PR when Fede asked #1969 (comment) ...

Ready for final review, or at least looks like it

This is a minimal Linux platformm intended to be useful with source plugins that do not handle syscall data but still want access to some info about the machine they're running on. Currently collected data includes: - machine info - agent info - interface list Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>

Rather than passing the mode directly, introduce a new enum that describes both the mode and the platform to use. Fixes: #2281 Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>

github-actions · 2024-08-01T09:16:19Z

Perf diff from master - unit tests

     1.19%     +1.97%  [.] sinsp::fetch_next_event
     1.43%     -0.93%  [.] scap_next
     4.64%     +0.57%  [.] next
     0.89%     +0.53%  [.] libsinsp::sinsp_suppress::process_event
     0.66%     +0.52%  [.] sinsp_evt::get_direction
     5.30%     -0.52%  [.] sinsp_parser::process_event
     1.61%     +0.51%  [.] scap_event_decode_params
     3.27%     +0.48%  [.] sinsp_thread_manager::get_thread_ref
     1.31%     -0.45%  [.] sinsp_evt::get_ts
     4.28%     -0.45%  [.] sinsp_evt::load_params

Perf diff from master - scap file

     3.52%     +7.71%  [.] sinsp_filter_check_thread::extract_single
     3.50%     +7.43%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
    16.71%     -6.89%  [.] sinsp_filter_check::extract_nocache
    15.31%     -6.12%  [.] next
     6.89%     +4.62%  [.] sinsp_filter_check_event::extract_single
     7.04%     +2.92%  [.] sinsp_filter_check::tostring
     3.52%     +2.16%  [.] sinsp_filter_check::extract
    10.38%     -2.05%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     3.61%     +1.67%  [.] sinsp_parser::reset
     3.52%     +1.46%  [.] sinsp_thread_manager::get_thread_ref

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

FedeDP

LGTM!
Also cc @mrgian

incertum

/approve

/hold to decide on when to merge it as we need to bump falco with these changes and do not want to block other updates in the meantime.

poiana · 2024-08-08T06:41:22Z

LGTM label has been added.

Git tree hash: d941eacc10bd46effbe92bebac9768bf5cb3d679

incertum · 2024-08-20T18:48:26Z

@FedeDP bump since you are back.

Also when would we want to unhold this and sync with a falco libs bump?

FedeDP · 2024-08-21T07:17:55Z

Also when would we want to unhold this and sync with a falco libs bump?

I'd say asap :) we have the libs bump PR opened since ages on Falco, it's time to sync with latest libs! Let's say next week :)

FedeDP

/approve

poiana · 2024-08-21T07:18:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, gnosek, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [FedeDP,gnosek,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

FedeDP · 2024-08-21T07:19:03Z

Also, since this is a breaking change, cc @Molter73

FedeDP · 2024-08-21T13:32:10Z

/unhold

The following PR in the libs falcosecurity/libs#1969 introduces a new platform for plugins that requires access to the proc filesystem. Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>

poiana added release-note-action-required dco-signoff: no kind/bug Something isn't working area/libscap area/libsinsp approved labels Jul 22, 2024

poiana requested review from FedeDP and hbrueckner July 22, 2024 06:14

poiana added the size/L label Jul 22, 2024

gnosek changed the title ~~Linux lite platform~~ new(scap, sinsp): linux_hostinfo platform for use with non-syscall source plugins Jul 22, 2024

gnosek force-pushed the linux-lite-platform branch from 90f8d8b to af5f096 Compare July 22, 2024 06:16

poiana added dco-signoff: yes and removed dco-signoff: no labels Jul 22, 2024

gnosek mentioned this pull request Jul 22, 2024

Regression: host metrics are not available running only source plugins falcosecurity/falco#2821

Closed

gnosek force-pushed the linux-lite-platform branch from af5f096 to 51e01cd Compare July 22, 2024 06:24

gnosek force-pushed the linux-lite-platform branch from 51e01cd to 7d27878 Compare July 22, 2024 06:42

gnosek force-pushed the linux-lite-platform branch from 7d27878 to ee8829e Compare July 22, 2024 06:51

poiana added dco-signoff: no and removed dco-signoff: yes labels Jul 22, 2024

gnosek force-pushed the linux-lite-platform branch from 1fb6fe1 to 7850607 Compare July 22, 2024 07:15

poiana added dco-signoff: yes and removed dco-signoff: no labels Jul 22, 2024

gnosek requested a review from incertum July 22, 2024 12:11

gnosek mentioned this pull request Jul 23, 2024

fix(libsinsp): enable metrics collector on all platforms #1870

Merged

FedeDP reviewed Jul 31, 2024

View reviewed changes

gnosek force-pushed the linux-lite-platform branch from 7850607 to 29e59f5 Compare August 1, 2024 09:08

new(sinsp)!: support linux_hostinfo_platform in sinsp::open_plugin

2118fcd

Rather than passing the mode directly, introduce a new enum that describes both the mode and the platform to use. Fixes: #2281 Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>

gnosek force-pushed the linux-lite-platform branch from 29e59f5 to 2118fcd Compare August 1, 2024 09:09

FedeDP reviewed Aug 1, 2024

View reviewed changes

incertum approved these changes Aug 8, 2024

View reviewed changes

poiana assigned incertum Aug 8, 2024

poiana added do-not-merge/hold lgtm labels Aug 8, 2024

leogr added this to the 0.18.0 milestone Aug 20, 2024

FedeDP approved these changes Aug 21, 2024

View reviewed changes

poiana assigned FedeDP Aug 21, 2024

poiana added release-note and removed release-note-action-required labels Aug 21, 2024

poiana removed the do-not-merge/hold label Aug 21, 2024

poiana merged commit 7b72eb5 into falcosecurity:master Aug 21, 2024
43 of 47 checks passed

FedeDP changed the title ~~new(scap, sinsp): linux_hostinfo platform for use with non-syscall source plugins~~ new(scap, sinsp)!: linux_hostinfo platform for use with non-syscall source plugins Aug 26, 2024

FedeDP mentioned this pull request Aug 26, 2024

update(cmake): bump libs and driver to latest master falcosecurity/falco#3283

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new(scap, sinsp)!: linux_hostinfo platform for use with non-syscall source plugins #1969

new(scap, sinsp)!: linux_hostinfo platform for use with non-syscall source plugins #1969

gnosek commented Jul 22, 2024 •

edited by FedeDP

Loading

github-actions bot commented Jul 22, 2024

github-actions bot commented Jul 22, 2024

codecov bot commented Jul 22, 2024 •

edited

Loading

github-actions bot commented Jul 22, 2024

github-actions bot commented Jul 22, 2024

github-actions bot commented Jul 22, 2024

github-actions bot commented Jul 22, 2024

incertum commented Jul 22, 2024

FedeDP Jul 31, 2024 •

edited

Loading

gnosek Jul 31, 2024

FedeDP Jul 31, 2024

incertum Jul 31, 2024

gnosek Aug 1, 2024

incertum Aug 8, 2024

gnosek Aug 8, 2024

github-actions bot commented Aug 1, 2024

FedeDP left a comment

incertum left a comment

poiana commented Aug 8, 2024

incertum commented Aug 20, 2024

FedeDP commented Aug 21, 2024

FedeDP left a comment

poiana commented Aug 21, 2024

FedeDP commented Aug 21, 2024

FedeDP commented Aug 21, 2024

new(scap, sinsp)!: linux_hostinfo platform for use with non-syscall source plugins #1969

new(scap, sinsp)!: linux_hostinfo platform for use with non-syscall source plugins #1969

Conversation

gnosek commented Jul 22, 2024 • edited by FedeDP Loading

github-actions bot commented Jul 22, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 22, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

codecov bot commented Jul 22, 2024 • edited Loading

Codecov Report

github-actions bot commented Jul 22, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 22, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 22, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

github-actions bot commented Jul 22, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

incertum commented Jul 22, 2024

FedeDP Jul 31, 2024 • edited Loading

Choose a reason for hiding this comment

gnosek Jul 31, 2024

Choose a reason for hiding this comment

FedeDP Jul 31, 2024

Choose a reason for hiding this comment

incertum Jul 31, 2024

Choose a reason for hiding this comment

gnosek Aug 1, 2024

Choose a reason for hiding this comment

incertum Aug 8, 2024

Choose a reason for hiding this comment

gnosek Aug 8, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 1, 2024

Perf diff from master - unit tests

Perf diff from master - scap file

Heap diff from master - unit tests

Heap diff from master - scap file

FedeDP left a comment

Choose a reason for hiding this comment

incertum left a comment

Choose a reason for hiding this comment

poiana commented Aug 8, 2024

incertum commented Aug 20, 2024

FedeDP commented Aug 21, 2024

FedeDP left a comment

Choose a reason for hiding this comment

poiana commented Aug 21, 2024

FedeDP commented Aug 21, 2024

FedeDP commented Aug 21, 2024

gnosek commented Jul 22, 2024 •

edited by FedeDP

Loading

codecov bot commented Jul 22, 2024 •

edited

Loading

FedeDP Jul 31, 2024 •

edited

Loading